Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the secret data struct #125

Merged
merged 11 commits into from
Apr 6, 2022
Merged

Change the secret data struct #125

merged 11 commits into from
Apr 6, 2022

Conversation

rishabh-arya95
Copy link
Member

@rishabh-arya95 rishabh-arya95 commented Apr 6, 2022 •
edited
Loading

Description

Change the secret data struct to make it uniform
Fixes #122

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested E2E using GH webhook

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@rishabh-arya95 rishabh-arya95 changed the title Dev Change the secret data struct Apr 6, 2022
@rishabh-arya95 rishabh-arya95 merged commit ccd913d into LambdaTest:dev Apr 6, 2022
@rishabh-arya95 rishabh-arya95 deleted the dev branch April 6, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabh-prakash saurabh-prakash saurabh-prakash approved these changes

@VikrantKS VikrantKS VikrantKS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishabh-arya95 @saurabh-prakash @VikrantKS