Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ftm task level #128

Merged
merged 19 commits into from
Apr 8, 2022

Conversation

rishabh-arya95
Copy link
Member

@rishabh-arya95 rishabh-arya95 commented Apr 7, 2022

Issue Link

Resolves #127

Description

Create FTM mode in nuclues

Fixes # (issue)

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested using premerge webhook.
  • Tested using postmerge webhook.
  • Tested auto quarantine feature.
  • Tested by deliberately failing discovery, execution and ftm tasks.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@saurabh-prakash saurabh-prakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. Else, lgtm

config/nucleusmodel.go Outdated Show resolved Hide resolved
pkg/core/lifecycle.go Outdated Show resolved Hide resolved
palashmarantas
palashmarantas previously approved these changes Apr 8, 2022
@rishabh-arya95 rishabh-arya95 merged commit dbda06a into LambdaTest:dev Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants