Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for both Yml and yaml extensions #18

Merged
merged 5 commits into from
Feb 23, 2022
Merged

Adding support for both Yml and yaml extensions #18

merged 5 commits into from
Feb 23, 2022

Conversation

rishabh-arya95
Copy link
Member

@rishabh-arya95 rishabh-arya95 commented Feb 20, 2022 •
edited
Loading

Closes #20

Description

  • Adding support for both Yml and yaml extensions
  • Fix typos and reduce linting issues.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested using GitHub webhook

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

saurabh-prakash
saurabh-prakash reviewed Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@saurabh-prakash saurabh-prakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @rishabh-arya95 Can you create a GitHub issue for the same also?

saurabh-prakash
saurabh-prakash approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@saurabh-prakash saurabh-prakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saurabh-prakash saurabh-prakash merged commit f7234e1 into LambdaTest:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabh-prakash saurabh-prakash saurabh-prakash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add support for supporting both yml and yaml extensions
2 participants
@rishabh-arya95 @saurabh-prakash