Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for docker volumes #198

Merged
merged 6 commits into from
Jul 15, 2022

Conversation

nevilm-lt
Copy link
Contributor

@nevilm-lt nevilm-lt commented Jun 23, 2022

Issue Link

#200

Description

Using docker volumes instead of mounting host path to the container for caching.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Run a build and verifying docker volumes are created by tas-build-<build-id>
  • Verified deletion of docker volumes after 4 hours (it deletes only the volume with prefix tas-build-)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nevilm-lt nevilm-lt requested review from saurabh-prakash and VikrantKS and removed request for saurabh-prakash June 23, 2022 07:12
Copy link
Collaborator

@saurabh-prakash saurabh-prakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. minor suggestion.

pkg/runner/docker/docker.go Outdated Show resolved Hide resolved
@nevilm-lt nevilm-lt added the release:minor Releases minor version of application label Jul 13, 2022
@saurabh-prakash saurabh-prakash merged commit 9506bd2 into LambdaTest:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Releases minor version of application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants