Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docker test #24

Merged
merged 7 commits into from
Mar 9, 2022
Merged

Conversation

VikrantKS
Copy link
Contributor

@VikrantKS VikrantKS commented Feb 22, 2022

Issue Link

#23

Description

This PR includes

  • Docker test cases
  • Fix stop and removal of spawned docker containers if synapse stops gracefully
    Note : We cannot remove spawned docker containers if synapse is killed forcefully

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested locally
  • Tested with unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saurabh-prakash saurabh-prakash mentioned this pull request Feb 22, 2022
1 task
@saurabh-prakash saurabh-prakash changed the base branch from master to dev March 8, 2022 05:28
Copy link
Member

@rishabh-arya95 rishabh-arya95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only minor comments, rest lgtm

cmd/synapse/bin.go Outdated Show resolved Hide resolved
pkg/runner/docker/docker.go Outdated Show resolved Hide resolved
cmd/synapse/bin.go Outdated Show resolved Hide resolved
saurabh-prakash
saurabh-prakash previously approved these changes Mar 9, 2022
@saurabh-prakash saurabh-prakash merged commit 7c379ad into LambdaTest:dev Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants