Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimisation: Reuse workspace between discovery and execution tasks #28

Merged
merged 5 commits into from
Mar 3, 2022

Conversation

saurabh-prakash
Copy link
Collaborator

Description

Performance optimisation: Reused workspace between discovery and execution tasks. Previously, we used to run the preRun commands again in execution mode of nucleus. With this change, execute tasks start using the workspace already set up by discover task.

Fixes # (issue)
Reduces the preRun setup latency contribution by half.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This has been tested locally with an express webhook. Observed that all tests ran successfully and test-execution phase continued on the workspace created by test-discovery phase

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saurabh-prakash saurabh-prakash merged commit 2bc6c3a into master Mar 3, 2022
@saurabh-prakash saurabh-prakash deleted the reuse-workspace branch March 3, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants