Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit tests #4

Merged
merged 13 commits into from
Mar 10, 2022
Merged

add unit tests #4

merged 13 commits into from
Mar 10, 2022

Conversation

sachinkumargit
Copy link
Contributor

@sachinkumargit sachinkumargit commented Feb 16, 2022 •
edited
Loading

Issue Link

Resolves #21

Description

Adding unit tests for nucleus packages

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ N/A] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ N/A] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ N/A] This change requires a documentation update

How Has This Been Tested?

  • Tested individual tests on local using 'go test' command
  • [ N/A] Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ N/A] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [ N/A] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • [ N/A] Any dependent changes have been merged and published in downstream modules

@saurabh-prakash
Copy link
Collaborator

@sachinkumargit Please create a GitHub issue and link it here. Also, do fill in the PR template sections completely.

saurabh-prakash
saurabh-prakash reviewed Feb 21, 2022
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@saurabh-prakash saurabh-prakash changed the base branch from master to dev March 9, 2022 10:06
Sachin Kumar and others added 13 commits March 9, 2022 16:05
@sachinkumargit
add unit tests
991b40b
@sachinkumargit
add unit tests
97b0225
@sachinkumargit
fix linting and cyclomatic complexity issues
a753a88
@sachinkumargit
fix case sensitive folder rename
3c0d393
@sachinkumargit
fix path error in fileutils tests and secret tests
2eebd47
@sachinkumargit
add unit tests for utils, gitmanager package of nucleus
83c8cc2
@sachinkumargit
remove commented 'testdata' in .gitignore, and fix linting issues
26a69ba
@sachinkumargit
fix lint issue in urlmanager
1c7e8d6
@sachinkumargit
add removeCreatedPath func to secret_test, and add comments on nucleu…
f21d1ea 
…s constants to fix lint issue
@sachinkumargit
converted subtests to table driven tests (TDD) for diffmanager, fileu…
1a21d27 
…tils, gitmanager, payloadmanager, secret, task packages and updated testutils files
@sachinkumargit
fix secret test and lint errors
1876638
@sachinkumargit
fix secret_test failing in CI
25a23ce
@sachinkumargit
update diffmanager and payloadmanager after rebasing
1b6d732
@saurabh-prakash saurabh-prakash merged commit 12d7ac6 into LambdaTest:dev Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevilm-lt nevilm-lt nevilm-lt left review comments

@rishabh-arya95 rishabh-arya95 rishabh-arya95 approved these changes

@saurabh-prakash saurabh-prakash saurabh-prakash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add unit tests for Nucleus packages
4 participants
@sachinkumargit @saurabh-prakash @rishabh-arya95 @nevilm-lt