Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle blocktests #54

Merged
merged 10 commits into from
Mar 14, 2022
Merged

Conversation

palashmarantas
Copy link
Contributor

@palashmarantas palashmarantas commented Mar 9, 2022

Issue Link

Added a generic blocktests support for blocklist and quarantined tests

Description

Added a generic blocktests support for blocklist and quarantined tests

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test With runners and postman
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@saurabh-prakash saurabh-prakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palashmarantas Can you do a git mv for setup.go file? It is showing as added and removed right now losing the git history.

pkg/core/models.go Outdated Show resolved Hide resolved
@palashmarantas palashmarantas force-pushed the handle_blocktests branch 2 times, most recently from 3734f61 to c4afc62 Compare March 11, 2022 19:36
@saurabh-prakash
Copy link
Collaborator

Trusting the 2 reviewers. Merging.

@saurabh-prakash saurabh-prakash merged commit e29577d into LambdaTest:dev Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants