Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proper error handling in case blob not found #57

Merged
merged 1 commit into from
Mar 10, 2022
Merged

proper error handling in case blob not found #57

merged 1 commit into from
Mar 10, 2022

Conversation

rishabh-arya95
Copy link
Member

Description

Proper error handling in case blob is not found

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested by trying to download a blob which does not exists

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saurabh-prakash saurabh-prakash merged commit f67d6fb into dev Mar 10, 2022
@saurabh-prakash saurabh-prakash deleted the hotfix/blob-not-found branch March 10, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashmarantas palashmarantas palashmarantas approved these changes

@saurabh-prakash saurabh-prakash saurabh-prakash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishabh-arya95 @saurabh-prakash @palashmarantas