Feature/synapse bitbucket #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/synapse-bitbucket_PHX-2614
…mbdatest/test-at-scale into feature/synapse-bitbucket_PHX-2614
VikrantKS
approved these changes
Mar 24, 2022
rishabh-arya95
approved these changes
Mar 24, 2022
saurabh-prakash
added a commit
that referenced
this pull request
Mar 28, 2022
* Init git while cloning (#67) * Init git while cloning * fixed tests * Fixed logging * synapse ws reconnect (#42) * added retry websocket connection logic * added connection abort functionality if duplicate connection requested * added entry in go.mod and go.sum , change restart policy in docker-compose * fix logout when graceful shutdown * refactor code and resolve review comments * change gracefultimeout for synapse from ms to s * update json keys for test suite payload (#70) * update json keys for test suite payload * fixed unit test cases * added refresh token api (#69) * added refresh token api * added unit tests * added unit test for secret parser expired function * disable golangci for false positive case * added comments * Update README.md (#58) (#76) Co-authored-by: Saurabh Prakash <saurabhp@lambdatest.com> * updated readme for ambiguity (#77) updated readme for ambiguity * Update main.yml (#79) * Feature/synapse bitbucket (#80) * added refresh token api * added unit tests * added unit test for secret parser expired function * disable golangci for false positive case * added comments * added token type * added gitprovider condition in refresh oauth * added basic auth supprt in git init * fixed spelling * fixed unit tests * fixed unit test * Changes get oauth secret test * Bugfix/bitbucket fork pr (#84) * added refresh token api * added unit tests * added unit test for secret parser expired function * disable golangci for false positive case * added comments * added token type * added gitprovider condition in refresh oauth * added basic auth supprt in git init * fixed spelling * fixed unit tests * fixed unit test * Changes get oauth secret test * updated readme for ambiguity (#77) updated readme for ambiguity * Update main.yml (#79) * added bitbucket forked pr support Co-authored-by: Nevil Macwan <93511721+nevilm-lt@users.noreply.github.com> Co-authored-by: Saurabh Prakash <saurabhp@lambdatest.com> * Removed parsing pod (#52) * Removed parsing pod * stable * updated tests * Added golangci lint file * Disabled lint checks for unblocking this change * Addressed PR comments Co-authored-by: VikrantKS <96419531+VikrantKS@users.noreply.github.com> Co-authored-by: palashmarantas <91466368+palashmarantas@users.noreply.github.com> Co-authored-by: utkarsh-lambdatest <98745310+utkarsh-lambdatest@users.noreply.github.com> Co-authored-by: Nevil Macwan <93511721+nevilm-lt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link
No support for bitbucket app password
Description
In the case of Bitbucket cloud, there is no personal access token instead they provide app passwords that can be used with username to authorize using Basic AUTH.
Authorization: "Basic " + b64.StdEncoding.EncodeToString([]byte(userid:apppassword))
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: