[Feature]: Support for execution logs files #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevilm-lt
changed the title
nevilm-lt
changed the title
pkg/runner/docker/docker.go
Outdated
| @@ -271,3 +278,35 @@ func (d *docker) PullImage(containerImageConfig *core.ContainerImageConfig, r *c | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func (d *docker) WriteLogs(ctx context.Context, r *core.RunnerOptions) error { | |||
There was a problem hiding this comment.
do we need to export this? Otherwise, lowercase it.
There was a problem hiding this comment.
Created internal function.
VikrantKS
approved these changes
Mar 29, 2022
saurabh-prakash
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link
#91: Support for execution logs files.
Description
Adds support to create a new log file for each container spawned for build task.
Logs will be generated in
/var/log/synapse/<jobID>/<containerName>.logfolder inside container which is mounted withcurrent directory(./logs/synapse) in docker-compose file.Log files will contain nucleus container stdout/stderr logs.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: