keyword arguments resolved to None instead of default values when using inject(cast=False)

[marcodlk]

Hi, first of all - thanks for creating fastdepends. Big fan!

Recently, ran into some unexpected behavior which does not appear intended. When inject(cast=False) is used, keyword arguments are resolved to None instead of the default value. For example, in the code below, get_hello() returns "hello, None" instead of "hello, world".

from fast_depends import Depends, inject

def get_world(value: str = "world"):
    return value

@inject(cast=False)
def get_hello(world: str = Depends(get_world)):
    return f"hello, {world}"

print(get_hello())  # Output: hello, None

When inject(cast=True) is used, the default values are used as expected.

The source of the issue appears to be the following lines in core/build.py:

FastDepends/fast_depends/core/build.py

Lines 174 to 177 in eebb26d

	if param.kind is param.KEYWORD_ONLY:
	keyword_args.append(param_name)
	elif param_name not in ("args", "kwargs"):
	positional_args.append(param_name)

In this case, param.kind is param.POSITIONAL_OR_KEYWORD, which is not param.KEYWORD_ONLY, so the param_name gets added to the positional_args list instead of keyword_args.

Is this intended behavior? It was unexpected to me and feels like an inconsistency.

[Lancetnik]

@marcodlk thank you for the Issue! I think, this is the bug and we should fix it. Unfortunatelly, I am too busy with FastStream now, but planning to make FastDepends sprint next month

[marcodlk]

Sounds good. Not too much rush - thanks to your flexible design, I can just use a wrap_model function to make necessary patch in the meantime :)

[marcodlk]

Ok it will be a bit trickier to patch than I thought. I believe the following line will need to be changed...

FastDepends/fast_depends/core/model.py

Line 296 in eebb26d

kwargs_ = {arg: solved_kw.get(arg) for arg in keyword_args}

...to something like this:

kwargs_ = {arg: solved_kw[arg] for arg in keyword_args if arg in solved_kw}

In the current logic, the solved_kw does not contain the value, so the params in keyword_args get value set to None and the None is injected as the keyword arg in the function call, overwriting the default.