Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022 Refresh (exe name change, cleanup build, cleanup repo) #1149

Closed
wants to merge 35 commits into from

Conversation

zach2good
Copy link
Contributor

@zach2good zach2good commented Dec 30, 2021

Lets:

  • Replace logos
  • Translate all the russian comments (search for: ж, и, д, ь, ч)
  • Replace manual command line arg parsing with argparse
  • Death to extern
  • Death to int8* strings
  • Death to tab and other strange whitespace
  • Death to useless comments
  • All the LGTM alerts (c++, python)
  • Yearly run of the SAN family
  • World server 🌎
  • Move messaging service to world server
  • Typesafe settings
  • Audit logging categories/formatting

Done:

  • Remove all those compiler flags TODOs and make the build bulletproof.
  • Audit compiler flags
  • Finish the de-branding effort
  • Clear out any files and scripts that are hanging around that people shouldn't be using
  • Translate all the french comments (search for: dans, pas, le, la, une, l', avec, un) (Thanks Nyu!)
  • Update sol: https://github.com/ThePhD/sol2/tree/develop (not needed)
  • ConsoleService (console input handling) for all exe's
[03/05/22 15:46:07:118][world][info][status] Console input thread is ready... (ConsoleService::ConsoleService:73)
[03/05/22 15:46:07:118][world][info][status] Type 'help' for a list of available commands. (ConsoleService::ConsoleService:74)
help
> Available commands:
> help : Print a list of available console commands.
> exit : Terminate the program.
> stats : Print server runtime statistics
stats
TODO: Some stats!
exit
Goodbye!
C:\ffxi\server\xi_world.exe (process 27908) exited with code 3.
  • Bring back ccache and add to docs
  • Better use of ZMQ
  • Add Cache.cmake information to docs
  • Remove the sub-libraries in the build, they don't really help with anything
  • Update Tracy to 0.7.8
  • Rename exes
  • Update compiler versions in CI, depending on what github wants to give us per platform (still C++17)
  • Refresh CMake, more use of CPM, better application of build flags between ext.deps and internal code

Relies on:

Experiments:

Afterwards:

  • Combine quick start guide and other longer guides into simple to follow setup guides with spoiler-tag areas which have more information
  • Make sure CMake setup guides for Win/Linux are still correct
  • Update "What Works" docs
  • Refresh contributor guide, style guide, issue/pr templates
  • Wiki article explaining everything that has just happened, and why, and what it enables
  • Make sure all references to Topaz and tpzdb etc. are removed from docs and wiki

In later PRs:

  • dbtool.py refresh
  • Navmesh/pathing rewrite
  • Login rewrite
  • Search rewrite

I affirm:

  • I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
  • that I agree to LandSandBoat's Limited Contributor License Agreement, as written on this date
  • that I have read the Contributing Guide
  • that I've tested my code and things my code changed since the last commit in the PR, and will test after any later commits

@TeoTwawki
Copy link
Contributor

related discussions at #1033 (linked to keep pr chatter clean)

@zach2good zach2good force-pushed the 2022_refresh branch 2 times, most recently from 0a33063 to 8372079 Compare January 9, 2022 11:14
@zach2good zach2good force-pushed the 2022_refresh branch 2 times, most recently from 7a7b163 to 611f861 Compare February 12, 2022 10:05
@zach2good zach2good force-pushed the 2022_refresh branch 2 times, most recently from b83af84 to bbb9e59 Compare March 15, 2022 14:58
@zach2good zach2good force-pushed the 2022_refresh branch 5 times, most recently from e1c3af1 to 5fcd91a Compare April 6, 2022 07:21
/wd4701 # potentially uninitialized local variable used
/wd4702 # unreachable code
/wd4703 # potentially uninitialized local pointer variable used
4189: 'scaleOver75': local variable is initialized but not referenced
4389: '==': signed/unsigned mismatch
4701: potentially uninitialized local variable
4702: unreachable code
4703: potentially uninitialized local pointer variable
4706: assignment within conditional expression
warning C4018: '<': signed/unsigned mismatch
warning C4389: '!=': signed/unsigned mismatch
@zach2good
Copy link
Contributor Author

Dropping this PR in favour of: #1749

@zach2good zach2good closed this May 18, 2022
@zach2good zach2good deleted the 2022_refresh branch July 15, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants