Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocr.nf cannot find FoLiA-hocr output files #30

Closed
peterdekker opened this issue May 28, 2018 · 2 comments
Closed

ocr.nf cannot find FoLiA-hocr output files #30

peterdekker opened this issue May 28, 2018 · 2 comments
Assignees
Labels

Comments

@peterdekker
Copy link

When running ocr.nf, the expected file format outputted by FoLiA-hocr is the basename of the original file + *.folia.xml: https://github.com/LanguageMachines/PICCL/blob/master/ocr.nf#L229

However, since the fix for issue LanguageMachines/foliautils#21, "id-" is prepended to filenames starting with a number by FoLiA-hocr: LanguageMachines/foliautils@6af7fa4
Now ocr.nf cannot find the files outputted by FoLiA-hocr anymore.

Not all files get the "id-" prefix from FoLiA-hocr, only the ones starting with a number. So a solution could be to make ocr.nf look for a broader output pattern. Or maybe FoLiA-hocr should add the "id-" prefix to all files, and ocr.nf could always look for this prefix.

@kosloot @proycon

@proycon proycon self-assigned this May 28, 2018
@proycon proycon added the bug label May 28, 2018
@proycon
Copy link
Member

proycon commented May 28, 2018

Ouch, this is indeed a regression introduced by that fix.

@kosloot We indeed need a very consistent predictable naming from FoLiA-hocr otherwise PICCL doesn't know what to look for.

@kosloot
Copy link

kosloot commented May 28, 2018

I am not sure that it is up to FoLiA-hocr to fix all the PICCl/nextflow issues :p, but OK
more on this here: LanguageMachines/foliautils#21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants