Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] extra headers disableResponsiveTable #4734

Closed
adriallongarriu opened this issue Oct 21, 2022 · 3 comments
Closed

[Bug] extra headers disableResponsiveTable #4734

adriallongarriu opened this issue Oct 21, 2022 · 3 comments
Labels

Comments

@adriallongarriu
Copy link
Contributor

Bug report

What I did

Use $this->crud->disableResponsiveTable();

What I expected to happen

Show all columns with scroll independent of the screen size.

What happened

When ussing $this->crud->disableResponsiveTable(); adds a tag <thead> on top and a tag <tfoot> on bottom.

Screenshot normal table ResponsiveTable enable
imagen

Screenshot table ResponsiveTable disabled
imagen
imagen

Is it a bug in the latest version of Backpack?

After I run composer update backpack/crud the bug... is it still there?

Yes

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

PHP 8.1.5

LARAVEL VERSION:

v9.36.4@15ce569fd93124e8e2257c24e3ed85b9ef9951d6

BACKPACK VERSION:

5.4.4@6dfaaf36c919be3b2873b66169dbb942df1245d5

@pxpm
Copy link
Contributor

pxpm commented Oct 25, 2022

Hello @adriallongarriu

I guess this is an updated application ? I say that because I see on your screenshot that the arrows to order the columns on top of the table also changes when you disable the responsive table, and we fixed that in #4490 so probably you should republish backpack assets with php artisan vendor:publish --provider="Backpack\CRUD\BackpackServiceProvider" --tag="public" --force

If you overrided any files in the public/packages folder make sure you do a backup first in case anything goes wrong.

As you can see from that PR, there is a pending issue that we are working on about the headers alignment.

I will be closing this issue, as this particular issue have already been fixed.

Cheers

@pxpm pxpm closed this as completed Oct 25, 2022
@pxpm pxpm moved this to Done in This week Oct 25, 2022
@adriallongarriu
Copy link
Contributor Author

Hello @pxpm,

I create a new project and blow last items it seems a bar white in the first column and grey in the follow.
imagen

I tested and sems to be only on Firefox. On Chrome it show different add and extra space between first and second column.
imagen

As it is an option that I do not use much, I leave it as it is for now.
Thank you

@pxpm
Copy link
Contributor

pxpm commented Oct 28, 2022

@adriallongarriu thanks for getting back here. @promatik is already working on a solution for it. 👍

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants