-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Separate responsive controls from first column contents not showing #5755
Comments
Based on the information provided in your question and the knowledge sources available, it appears you are experiencing an issue with the responsive controls and action buttons not displaying properly in Backpack's datatable when you have a large column title. This seems to be a known issue that has been reported and addressed in previous versions of Backpack. A similar issue was reported in Github Issue #4352, where the ellipsis (three dots) and modal were not showing up correctly when clicked. The issue was fixed in a subsequent release. To address your specific problem, I would recommend trying the following steps:
It's worth noting that the behavior of responsive controls and action buttons has changed in different versions of Backpack, so make sure you're following the latest documentation for your specific version. If the problem continues after trying these steps, I recommend reaching out to the Backpack community or creating a new issue on their GitHub repository with specific details about your setup and screenshots demonstrating the problem. ℹ️ Please note our AI Bot does not reply to follow-ups, this will be the only AI answer in this thread. If the AI helped you find the answer, please mark it as answered or write details below so it can learn. Then close the conversation. If not, please give more information for when a human reads this. ℹ️ Relevant sources: Github Issue (closed): Bug on table responsive mode |
php artisan vendor:publish --provider="Backpack\CRUD\BackpackServiceProvider" --tag=public --force nothing change |
Thanks @dilneiss I will have a look at it, but not sure it's related with the change I made in the other PR. Will see, I will do some testing and get back to you 👍 Cheers |
@pxpm find anything? |
Hey @dilneiss sorry I did, but I forgot to get back here. I don't think the issue you are facing relates with the change you mentioned. From your screenshot I don't think you have responsive table enabled, as I can't see the "three dots" even on the desktop you said it's working. Regarding the actions buttons not showing on mobile I think there is an issue there, but it will require further investigation. Can you clarify exactly what's your issue ? (apart from actions not showing on mobile). Cheers |
@pxpm I do have the responsive table enabled, the 3 dots appear correctly when I have a column in the list with a smaller number of characters, now if they get too big the 3 dots don't appear :(, both it and the action button.. |
I'm pretty sure that this change caused the issue - If I switch back and forth between backpack-crud 6.7.43 (broken) and 6.7.41 I can make it work again. I think 6.7.42 included the merge #5719 I'm on Laravel 10.48.25 and have several backpack extensions installed. And thanks for getting back to us @pxpm :) |
@falterkofler, @pxpm yes, the problem is here right in this code: i changed it to as it was before commit and now is showing plus button and actions button.
please check again |
Thanks, I will take another look at this 👍 |
I've spent quite some time trying to reproduce this issue. Unfortunately I was not able to. Here are the test I have done: After I resized the window, and tried also changing to mobile: I notice that you don't have the three dots like I have. Is is possible that you are using a different css than me ? Do you have files overwritten in your The fact the actions disappear for long text columns is an old "issue", not related with any recent changes. By any chance any of your guys projects are public so that I can have a look at ? Cheers |
@pxpm maybe because i am using coreuiv4 theme? when i inspect that plus button, i can see this coreuiv4 load from here: /assets/basset/vendor/backpack/theme-coreuiv4/resources/assets/css/coreui4.css?19a7d2fc2f12 and that plus button is comming from here: https://cdn.datatables.net/responsive/2.4.0/css/responsive.dataTables.min.css?19a7d2fc2f12 |
@dilneiss thanks for the screenshot. We are getting somewhere. 👍 That's a different output from what I got on my side. On my side, the "three dots" (in your case the green sign), is coming from
I am also using coreui-v4 in this screenshot. Can you figure out why Cheers |
@pxpm common.css is loading, check my |
Thanks @dilneiss Can you check if you have the updated version of Specifically this change: Cheers |
@pxpm yes, i have it: #crudTable_wrapper #crudTable.dtr-none > tbody > tr > td > div.dtr-control:before, |
Hey @dilneiss I am sorry but I am still unable to reproduce the issue. It seems something is off on your screenshot in comparison with my results. As you can see from my screenshot, my That's coming from
I've just created a new application to make sure it "should" be working as expected, can you please install this project https://github.com/pxpm/testbug and reproduce there the issue ? Cheers |
@pxpm i found the problem, try adding CRUD::column('id')->type('number')->label('ID')->priority(5); (any priority) |
Thanks @dilneiss , but that still doesn't break it for me: I suspect the issue is some core view you have published in your You can check on the project I shared, I added the Can you reproduce your issue in that project ? |
@pxpm you have to resize your window to a smaller one, i made this bug on your project https://github.com/pxpm/testbug |
Thanks a lot @dilneiss for the time spent helping me figuring out the issue 🙏 Also thanks @falterkofler 🙏 I was able to reproduce it, and fixed it in 6.7.52, dtr-controls should now always be positioned at the first visible column. I also bumped into the "green icon" issue, I was able to fix it by doing a Let me know if things are working now for you after the update. Cheers |
thanks @pxpm we are almost there! |
Thanks @dilneiss sorry I've tested this in the I've fixed it in 6.7.54, you can run a Cheers |
i ran i had to run this : php artisan basset:clear so the new now i can see the three dots again! Thank you! |
@pxpm thankyou! everything works now! |
Let me have a look to check if the checkbox need fix too 👍 |
done @dilneiss removed the checkboxes from single entry view. There is a possibility we may add the checkbox back, and link it with the column checkbox, but that would require quite a bit more work that we cannot spend time on now. If you tackle it, feel free to submit a PR and we will review it 👍 Thanks for your time and effort once again 🙏 |
Bug report
What I did
Listing items on datatable
What I expected to happen
show 3 dots and actions button
What happened
When i have a big column title, the 3 dots menu is not showing, also actions button dissapear
What I've already tried to fix it
nothing yet
Is it a bug in the latest version of Backpack?
Yes
After I run
composer update backpack/crud
the bug... is it still there?yes
Backpack, Laravel, PHP, DB version
When I run
php artisan backpack:version
the output is:PHP VERSION:
8.3.12
PHP EXTENSIONS:
Core, date, libxml, openssl, pcre, zlib, filter, hash, json, pcntl, random, Reflection, SPL, session, standard, sodium, mysqlnd, PDO, xml, bcmath, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gd, gettext, gmp, iconv, igbinary, imagick, imap, intl, exif, msgpack, mysqli, pdo_mysql, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, readline, redis, shmop, SimpleXML, soap, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl, zip, memcached, swoole, Zend OPcache
LARAVEL VERSION:
11.39.1.0
BACKPACK PACKAGE VERSIONS:
backpack/activity-log: 2.0.6
backpack/basset: 1.3.6
backpack/crud: 6.7.50
backpack/logmanager: v5.0.2
backpack/medialibrary-uploaders: 1.2.1
backpack/permissionmanager: 7.2.1
backpack/pro: 2.2.32
backpack/revise-operation: 2.0.0
backpack/settings: 3.1.1
backpack/theme-coreuiv4: 1.1.5
Additional Information
This is not showing 3 dots and actions button, chrome navigator, you can try resizing window

This is desktop version working

The text was updated successfully, but these errors were encountered: