Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ListOperation modal no longer showing when ellipsis is clicked #4352

Closed
tabacitu opened this issue May 2, 2022 · 2 comments
Closed

Comments

@tabacitu
Copy link
Member

tabacitu commented May 2, 2022

Bug report

What I did

Clicked the ellipsis (three dots ...) in the table view.

What I expected to happen

A modal to show up with all the columns for that entry, and the buttons, like it did in previous versions:

CleanShot 2022-05-02 at 10 39 26

What happened

The ellipsis shows up, but when clicked it triggers the details row, which sort of shows the same thing but not everything (the buttons for example aren't there), and in an ugly way:

CleanShot 2022-05-02 at 10 40 50

What I've already tried to fix it

Nothing yet. But I see the bug is also on demo.backpackforlaravel.com so I think it's been here for a few weeks at least 😔

Is it a bug in the latest version of Backpack?

After I run composer update backpack/crud the bug... is it still there?

Yup.

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

### PHP VERSION:
PHP 8.0.16 (cli) (built: Feb 18 2022 09:11:10) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.16, Copyright (c) Zend Technologies
    with Xdebug v3.0.4, Copyright (c) 2002-2021, by Derick Rethans
    with Zend OPcache v8.0.16, Copyright (c), by Zend Technologies

### LARAVEL VERSION:
v9.6.0@47940a1a8774b96696ed57e6736ccea4a880c057

### BACKPACK VERSION:
5.0.13@d78f4263f5eef1e7761ba2d55d81959f4de559b6
@tabacitu
Copy link
Member Author

tabacitu commented May 3, 2022

Update: I used the new asset commands in the demo, then I could switch between CRUD versions and their assets:

composer bp-assets-link
cd vendor/backpack/crud
git checkout 5.0.13 # the modal shows up
git checkout 5.0.14 # the modal does NOT show up

So it looks like the problem did originate in 5.0.14, which just happens to be when we fixed the responsive table header 😅 You can see the diff between the two versions here - 5.0.13...5.0.14 - but other than the CSS... I really can't see anything else that might have caused this. There is no DataTables version bump in 5.0.14 (thank god!)

@promatik can you please take a look? I think it'll be easiest for you to get to the bottom of this.

I hope my findings above help.

@promatik
Copy link
Contributor

Fix for this is here; #4377 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants