Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliases to provides() #30

Merged
merged 1 commit into from
May 6, 2015
Merged

Conversation

barryvdh
Copy link
Contributor

The ServiceProvider is deferred, thus only runs when something listed in provides() is requested. But when you use dependancy injection, the alias is used.

This adds those aliases. Fixes problems with TwigBridge (rcrowe/TwigBridge#194, rcrowe/TwigBridge#150, rcrowe/TwigBridge#156, rcrowe/TwigBridge#184)

(If you test, remember that php artisan clear-compiled is needed before changes are reflected in the app)

@barryvdh
Copy link
Contributor Author

Any problems with this?

tshafer added a commit that referenced this pull request May 6, 2015
Add aliases to provides()
@tshafer tshafer merged commit 8ae4aa0 into LaravelCollective:5.0 May 6, 2015
@barryvdh barryvdh deleted the patch-1 branch May 6, 2015 14:33
@barryvdh
Copy link
Contributor Author

barryvdh commented May 6, 2015

Thanks!

@tshafer
Copy link
Contributor

tshafer commented May 6, 2015

Sorry it took so long. :)

-- 
Tom Shafer
Sent with Airmail

From: Barry vd. Heuvel notifications@github.com
Reply: LaravelCollective/html reply@reply.github.com>
Date: May 6, 2015 at 7:33:56 AM
To: LaravelCollective/html html@noreply.github.com>
Cc: Tom tj@tjshafer.com>
Subject:  Re: [html] Add aliases to provides() (#30)

Thanks!


Reply to this email directly or view it on GitHub.

@malika261 malika261 mentioned this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants