Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed inconsistent dark: class from sub menu #130

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Removed inconsistent dark: class from sub menu #130

merged 1 commit into from
Mar 19, 2023

Conversation

alnahian2003
Copy link
Contributor

@alnahian2003 alnahian2003 commented Mar 19, 2023

Dark classes have not been used anywhere but in the Two Level Menu. Imagine someone reuses the sub-menu and the UI will start looking inconsistent already.
Screenshot_1

That's why I made this little PR removing all those unnecessary dark: classes from navigation menus

@PovilasKorop PovilasKorop merged commit 523acbf into LaravelDaily:main Mar 19, 2023
@alnahian2003 alnahian2003 deleted the patch-1 branch March 20, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants