update laravel ui and bootstrap version #81

RoduanKD · 2022-08-08T13:05:51Z

Hello!
I'm working on this now and here's the required todo

krekas · 2022-08-08T14:13:55Z

@RoduanKD keep in mind that there's very big chance not all themes will work only by changing to @vite directive.

remove ~ from app.scss

…nto add-vite-support-to-bootstrap-themes � Conflicts: � src/Console/InstallCommand.php

RoduanKD · 2022-08-13T14:02:36Z

I've tested manually all laravel/ui themes. all of them are fine except for Volt. please give it a second check @PovilasKorop @krekas. I'm not sure if the problem is from my side or no.

error details:

D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:27142
      throw error;
      ^

Invalid argument(s): Uri d:%5Claragon%5Cwww%5Clarastarters%5Cnode_modules%5C@fortawesome%5Cfontawesome-free%5Cscss%5Csolid.scss must have scheme 'file:'.
    at Object.wrapException (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:1235:17)
    at WindowsStyle.pathFromUri$1 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:32890:17)
    at StaticClosure.fromUri (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:16100:37)
    at Object.NullableExtension_andThen0 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:18332:40)
    at Object._wrapException (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:12997:14)
    at _render_closure1.call$2 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:81147:21)
    at _RootZone.runBinary$3$3 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:27268:18)
    at _FutureListener.handleError$1 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:25818:19)
    at _Future__propagateToListeners_handleError.call$0 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:26116:49)
    at Object._Future__propagateToListeners (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:4539:77) {
  dartException: <ref *1> ArgumentError {
    _hasValue: false,
    invalidValue: null,
    name: null,
    message: "Uri d:%5Claragon%5Cwww%5Clarastarters%5Cnode_modules%5C@fortawesome%5Cfontawesome-free%5Cscss%5Csolid.scss must have scheme 'file:'.",
    '$thrownJsError': <ref *2> Invalid argument(s): Uri d:%5Claragon%5Cwww%5Clarastarters%5Cnode_modules%5C@fortawesome%5Cfontawesome-free%5Cscss%5Csolid.scss must have scheme 'file:'.
        at Object.wrapException (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:1235:17)
        at WindowsStyle.pathFromUri$1 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:32890:17)
        at StaticClosure.fromUri (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:16100:37)
        at Object.NullableExtension_andThen0 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:18332:40)
        at Object._wrapException (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:12997:14)
        at _render_closure1.call$2 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:81147:21)
        at _RootZone.runBinary$3$3 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:27268:18)
        at _FutureListener.handleError$1 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:25818:19)
        at _Future__propagateToListeners_handleError.call$0 (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:26116:49)
        at Object._Future__propagateToListeners (D:\laragon\www\larastarters\node_modules\sass\sass.dart.js:4539:77) {
      dartException: [Circular *1],
      '$cachedTrace': _StackTrace {
        _exception: [Circular *2],
        _trace: "Invalid argument(s): Uri d:%5Claragon%5Cwww%5Clarastarters%5Cnode_modules%5C@fortawesome%5Cfontawesome-free%5Cscss%5Csolid.scss must have scheme 'file:'.\n" +
          '    at Object.wrapException (D:\\laragon\\www\\larastarters\\node_modules\\sass\\sass.dart.js:1235:17)\n' +
          '    at WindowsStyle.pathFromUri$1 (D:\\laragon\\www\\larastarters\\node_modules\\sass\\sass.dart.js:32890:17)\n' +
          '    at StaticClosure.fromUri (D:\\laragon\\www\\larastarters\\node_modules\\sass\\sass.dart.js:16100:37)\n' +
          '    at Object.NullableExtension_andThen0 (D:\\laragon\\www\\larastarters\\node_modules\\sass\\sass.dart.js:18332:40)\n' +
          '    at Object._wrapException (D:\\laragon\\www\\larastarters\\node_modules\\sass\\sass.dart.js:12997:14)\n' +
          '    at _render_closure1.call$2 (D:\\laragon\\www\\larastarters\\node_modules\\sass\\sass.dart.js:81147:21)\n' +
          '    at _RootZone.runBinary$3$3 (D:\\laragon\\www\\larastarters\\node_modules\\sass\\sass.dart.js:27268:18)\n' +
          '    at _FutureListener.handleError$1 (D:\\laragon\\www\\larastarters\\node_modules\\sass\\sass.dart.js:25818:19)\n' +
          '    at _Future__propagateToListeners_handleError.call$0 (D:\\laragon\\www\\larastarters\\node_modules\\sass\\sass.dart.js:26116:49)\n' +
          '    at Object._Future__propagateToListeners (D:\\laragon\\www\\larastarters\\node_modules\\sass\\sass.dart.js:4539:77)'
      }
    }
  }
}

krekas · 2022-08-13T14:05:26Z

@RoduanKD your error is with fontawesome. It cannot find manifest file. I think it could be manifest

RoduanKD · 2022-08-13T14:40:25Z

this issue was related to sass according to this I need to update sass to 1.38. it fixes the problem but puts me back one step because as of sass:1.32, using / operator is not allowed and shows a deprecation notice. I fixed the deprecations that are coming from volt (using sass-migrator) and the ones that are left are the ones coming from font awesome

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(20em, 16) or calc(20em / 16)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
12 │ $fa-fw-width:          (20em / 16);
   │                         ^^^^^^^^^
   ╵
    node_modules\@fortawesome\fontawesome-free\scss\_variables.scss 12:25  @import
    node_modules\@fortawesome\fontawesome-free\scss\fontawesome.scss 5:9   @import
    resources\sass\app.scss 1:9                                            root stylesheet

RoduanKD · 2022-08-13T14:42:55Z

PS: with the above fix it's working with deprecation notice for font awesome files. @krekas

krekas · 2022-08-13T18:03:05Z

@RoduanKD I checked your pr.

adminlte isn't working. Can't open dropdowns. And console shows error
coreui everything works.
plainadmin dropdown also not working
volt dropdown again
sb admin 2 also dropdowns. Getting jquery error in console
tabler everything seems working

RoduanKD · 2022-08-13T22:26:38Z

thanks for your check @krekas:

adminlte is fixed
plainadmin is fixed
volt is fixed
sb admin 2: sidebar toggle is working now and the jQuery error is gone but the dropdown didn't work and I didn't get why is that happening!

krekas · 2022-08-14T06:59:20Z

@RoduanKD

adminlte dropdown works only for menu, where user is doesn't
volt gives font error. I think it would be great to fix it
sb admin 2 is made using bootstrap 4. When downgraded works. I can't push directly to pr here so make these changes.
In replaceWithSBAdmin2() function at the start add

// NPM Packages...
$this->updateNodePackages(function ($packages) {
    return [
        "bootstrap" => "^4.6.2",
    ] + $packages;
}, dev: true);

In guest.blade.php replace css with @vite('resources/css/app.css') and in both layouts remove google fonts

PovilasKorop · 2022-08-20T06:08:42Z

@krekas ping, have you had the time to test the latest changes by @RoduanKD?

krekas · 2022-08-20T06:09:37Z

@PovilasKorop planning to check today

krekas · 2022-08-20T07:03:59Z

@RoduanKD change admin LTE npm packages to:

// NPM Packages...
$this->updateNodePackages(function ($packages) {
    return [
            'jquery'=> '^3.6.0',
            'resolve-url-loader' => '^4.0.0',
            'bootstrap' => '~4.6.1',
        ] + $packages;
}, dev: true);

this theme also uses old bootstrap version. After this fix everything works.

@PovilasKorop after this last fix green light from me.

PovilasKorop · 2022-08-20T07:10:18Z

@krekas could you maybe do it yourself and push to the branch of PR? Then we wouldn't need to wait for @RoduanKD

krekas · 2022-08-20T07:11:10Z

@PovilasKorop don't have permissions.

PovilasKorop · 2022-08-20T07:12:04Z

@krekas oh right, how could I forget. Ok waiting then.

RoduanKD · 2022-08-20T08:49:07Z

@keras, I've downgraded bootstrap in Admin LTE and had to downgrade jQuery & popper.js, and it's working fine now. I think it's now ready @PovilasKorop

PovilasKorop · 2022-08-22T07:21:40Z

@krekas can you approve that I should merge?

krekas · 2022-08-22T18:45:27Z

@PovilasKorop everything should be good, green light from me

update laravel ui and bootstrap version

009f0ec

RoduanKD mentioned this pull request Aug 8, 2022

Configuration with vite #80

Closed

RoduanKD added 2 commits August 8, 2022 16:23

add ~bootstrap alais to vite.config.js

ab18428

update coreui layouts

a735ffc

PovilasKorop mentioned this pull request Aug 9, 2022

Add Artisan Command Option #83

Merged

RoduanKD added 11 commits August 13, 2022 15:10

update coreui layouts (no need to vite bundled js files)

2c5f2f5

update plainadmin layouts

e904d10

replace vite.config.js when installing a laravel ui theme

7644ed6

fix: use base path not app path

e584c44

update volt layouts

d2b79ac

fix sass version on 1.32

c3df186

update tabler layouts

cdbd2f2

fix bootstrap version at 5.1.3

e190c92

remove ~ from app.scss

replace tabler require statements with ES import

2753abd

replace require statement in all js files

2f72efd

Merge branch 'main' of https://github.com/LaravelDaily/Larastarters i…

289d031

…nto add-vite-support-to-bootstrap-themes � Conflicts: � src/Console/InstallCommand.php

RoduanKD marked this pull request as ready for review August 13, 2022 13:58

migrate scss files of volt theme

8abed3d

RoduanKD added 4 commits August 14, 2022 00:29

fix: adminlte dropdown not working

bd57b5f

fix: plainadmin theme dropdown not working

9775852

fix: volt theme dropdown not working

e468464

fix: sb admin 2 sidebar toggle is not working

5b783cb

RoduanKD added 3 commits August 15, 2022 15:29

fix: sb admin issues by downgrading to bootstrap 4

7875802

add popper.js and jquery for sb admin 2

2e44461

use the proper popper.js version

5a9b786

PovilasKorop mentioned this pull request Aug 20, 2022

Add Vite support and improve console output #85

Merged

RoduanKD added 2 commits August 20, 2022 11:20

update AdminLTE bootstrap version

deb2c4b

update Admin LTE packages with the proper jQuery and popper.js versions

615e2bd

PovilasKorop merged commit 17c01b6 into LaravelDaily:main Aug 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update laravel ui and bootstrap version #81

update laravel ui and bootstrap version #81

RoduanKD commented Aug 8, 2022 •

edited

Loading

krekas commented Aug 8, 2022

RoduanKD commented Aug 13, 2022

krekas commented Aug 13, 2022 •

edited

Loading

RoduanKD commented Aug 13, 2022

RoduanKD commented Aug 13, 2022

krekas commented Aug 13, 2022

RoduanKD commented Aug 13, 2022

krekas commented Aug 14, 2022

PovilasKorop commented Aug 20, 2022

krekas commented Aug 20, 2022

krekas commented Aug 20, 2022

PovilasKorop commented Aug 20, 2022

krekas commented Aug 20, 2022

PovilasKorop commented Aug 20, 2022

RoduanKD commented Aug 20, 2022 •

edited

Loading

PovilasKorop commented Aug 22, 2022

krekas commented Aug 22, 2022

update laravel ui and bootstrap version #81

update laravel ui and bootstrap version #81

Conversation

RoduanKD commented Aug 8, 2022 • edited Loading

krekas commented Aug 8, 2022

RoduanKD commented Aug 13, 2022

krekas commented Aug 13, 2022 • edited Loading

RoduanKD commented Aug 13, 2022

RoduanKD commented Aug 13, 2022

krekas commented Aug 13, 2022

RoduanKD commented Aug 13, 2022

krekas commented Aug 14, 2022

PovilasKorop commented Aug 20, 2022

krekas commented Aug 20, 2022

krekas commented Aug 20, 2022

PovilasKorop commented Aug 20, 2022

krekas commented Aug 20, 2022

PovilasKorop commented Aug 20, 2022

RoduanKD commented Aug 20, 2022 • edited Loading

PovilasKorop commented Aug 22, 2022

krekas commented Aug 22, 2022

RoduanKD commented Aug 8, 2022 •

edited

Loading

krekas commented Aug 13, 2022 •

edited

Loading

RoduanKD commented Aug 20, 2022 •

edited

Loading