-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TravisCI Testing #19
Comments
Ok thanks, i'll give it a go. |
Click Settings, Tools, Open devtools? Its supposed to work. If you get that
far, it's usually through the gate (:
Just ran the linux builds here (Ubuntu 16.04.2) and they work. (git upload
still running. Have you tested one of the existing appimages? If the viewer
doesnt show up it could be a webgl problem on the machine)
…On Mar 22, 2017 6:07 PM, "Jonathan Beverley" ***@***.***> wrote:
OK so the manual build works but on running the AppImage file I get Lasweb
running just get a white area where the grid normally is. Did I miss
something?
[image: image]
<https://cloud.githubusercontent.com/assets/2034227/24207723/88193c16-0f19-11e7-9bd1-8e96c107430b.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVr2x7OfB7_wHom6dpHX8oIweUTXXiMks5roUclgaJpZM4MlZOE>
.
|
I just tried one of the builds you did and get the same so must be my machine. I can't get to the settings tab either. |
:( sorry
Just tested and can get to settings, viewer works, and devtools open from
the button under settings, tools. So must be.
…On Mar 22, 2017 6:18 PM, "Jonathan Beverley" ***@***.***> wrote:
I just tried one of the builds you did and get the same so must be my
machine.
I can't get to the settings tab either.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVr243zfnOf-TBvu5SfGQAt_5K3gXE4ks5roUnVgaJpZM4MlZOE>
.
|
Where can the AppImage be found? |
In github.com/LaserWeb/LaserWeb4-Binaries?
Or on a local build? (lw.comm-server/dist/
…On Mar 22, 2017 8:28 PM, "probonopd" ***@***.***> wrote:
Where can the AppImage be found?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVr20jkP2z25ELNFq8QPY0YGAcACJLNks5roWg0gaJpZM4MlZOE>
.
|
Err, why are you putting binary downloads in git rather than on GitHub Releases? That's totally abusing git and GitHub certainly won't like it. https://www.quora.com/Should-binary-files-be-stored-in-a-Git-repository |
Thats what I said just a couple hours ago, which led to this new issue, to
start automating build and release. (; feel free to help out instead of
judging lol
…On Mar 22, 2017 8:31 PM, "probonopd" ***@***.***> wrote:
Err, why are you putting binary downloads in git rather than on GitHub
Releases <https://github.com/LaserWeb/lw.comm-server/releases>? That's
totally abusing git and GitHub certainly won't like it.
https://www.quora.com/Should-binary-files-be-stored-in-a-Git-repository
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVr24pWA3bkgxvrpQRPatkWjvveVjkkks5roWj7gaJpZM4MlZOE>
.
|
Stalking you out on g+ you are actually exactly the skillset we have been
looking for https://plus.google.com/105493415534008524873/posts/HqrRabuEpjW
I'm fudging the builds in a a hacky way. We havent got a solution for
managing the versions of LaserWeb4 and lw.comm-server together into a
version to the name the builds (right now electron-builder gives them the
version from package.json in lw.comms-server
I'd be happy to give you push access if you can help us sort out the mess
for real (;
On Mar 22, 2017 8:32 PM, "Peter van der Walt (Gmail)" <
peter.plaaswerf@gmail.com> wrote:
… Thats what I said just a couple hours ago, which led to this new issue, to
start automating build and release. (; feel free to help out instead of
judging lol
On Mar 22, 2017 8:31 PM, "probonopd" ***@***.***> wrote:
> Err, why are you putting binary downloads in git rather than on GitHub
> Releases <https://github.com/LaserWeb/lw.comm-server/releases>? That's
> totally abusing git and GitHub certainly won't like it.
>
> https://www.quora.com/Should-binary-files-be-stored-in-a-Git-repository
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#19 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AHVr24pWA3bkgxvrpQRPatkWjvveVjkkks5roWj7gaJpZM4MlZOE>
> .
>
|
Happy to help if I can, but I am not an Electron expert at all. |
The Electron part itself seems good. Automating building them (as per OP
above) and then sure, extending it to be able to automate releases would be
cool. We can maybe use git hooks on LaserWeb4 and lw.comm-server repos to
trigger the builds (if anything changes on there) or releases on there?
Thats the stuff we don't know what best practices!
@jorgerobles @cprezzi @tbfleming
…On Mar 22, 2017 8:53 PM, "probonopd" ***@***.***> wrote:
Happy to help if I can, but I am not an Electron expert at all.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVr25kYmcWtMIcKEEqAGIFN5PjW0WD2ks5roW4zgaJpZM4MlZOE>
.
|
Invited you to the Organisation, will full devteam access (:
…On Mar 22, 2017 8:53 PM, "probonopd" ***@***.***> wrote:
Happy to help if I can, but I am not an Electron expert at all.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVr25kYmcWtMIcKEEqAGIFN5PjW0WD2ks5roW4zgaJpZM4MlZOE>
.
|
So, would you like to have automated continuous builds on each |
@probonopd - lets run that past @cprezzi (developer of the comms-server) and @jorgerobles / @tbfleming (the major frontend guys) for their call |
Travis or something else? Also not sure, we use node-serialport in the comms server and since its a native module, I couldnt get it to build crossplatform locally. I assume the same applies to the various CI services? |
It'd be nice if pushing to a specific branch caused it to create new binaries. It'd also be nice to have some way of marking known-good binaries. |
I have it working when you push to the electron_bundler branch Travis will build the linux AppImage and upload it to an S3 bucket. I have also set a daily cron to do the same. Here is the latest file that it built - http://laserweb-release.s3-website-us-east-1.amazonaws.com/laserweb-release/LaserWeb/lw.comm-server/10/10.1/dist/lw.comm-server-4.0.45-x86_64.AppImage Clearly needs more work but at least there is something working. |
I also have it building the AppImage for each commit to Laserweb4. If you click on the green tick next to the commit, it will take you to Travis, scroll down to the bottom of the log and there is a link to the artifact. I'll see what I can do about cross platform builds next. |
This is soooo awesome!
…On Mar 23, 2017 8:44 AM, "Jonathan Beverley" ***@***.***> wrote:
I also have it building the AppImage for each commit to Laserweb4. If you
click on the green tick next to the commit, it will take you to Travis,
scroll down to the bottom of the log and there is a link to the artifact.
I'll see what I can do about cross platform builds next.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHVr25fvvioDbE6KkXVOE41T6L_yWpbVks5rohTSgaJpZM4MlZOE>
.
|
Just knocked up a lambda function to maintain a list of files in the bucket here - |
@jonbev Can you explain this thread (in non technical language) and how we can use it OR how it will fit into the big picture? |
It basically just means that there is a build available for every commit. Just makes it easy for non technical people to use the latest build as they dont need to use git and npm etc. |
@jonbev Thanks for the explanation. Is it up and running yet? If so, where can we find the various builds? |
I have only managed to get it working on linux build so far. I attempted windows but couldn't get it working as Travis runs on Ubuntu so made it very difficult. Could probably do with someone who has a clue about macs to have a look at the mac build as Travis does support them. The link to a list of builds is here - http://laserweb-release.s3-website-us-east-1.amazonaws.com/ with the newest at the top. |
We are compiling mac builds locally using the procedure outlined by Peter. It works very reliably for Mac but we do have problems with Win builds and often have to re-clone and do some manual deletions to lw.comms directory to get it to pick up the latest versions and build correctly. |
I updated the LaserWeb4-Binaries repo and removed the linux nighly builds. The readme on LaserWeb4 binaries now redirect to the S3 bucket |
The linux builds are working so awesomely flawless!!!! Any chance we can ask you to take another look at getting Windows/Mac builds working? (; As I understand, TravisCI doesnt do Windows native modules, but AppVeyor can: http://hoverbaum.gitlab.io/2016/08/03/Building-Electron-based-applications-using-CIs/ If its paywall related issues, let me know, and we can make a plan around those |
PS: @probonopd - i also took your advice... Releases for Windows are now on https://github.com/LaserWeb/LaserWeb4-Binaries/releases (for now, until we get the CI figured out with node-serialport needed a native windows environment to compile) Linux builds are on the Amazon Bucket Mac... Hmmm, well, for now, nowhere! Yikes! |
Thank you very much. Unfortunately the nightly AppImage does not work for me:
Possibly libnss3 and friends need to be bundled inside the AppImage then, also see probonopd/linuxdeployqt#35. |
@jonbev
Okay, so, the way we currently build LW4 binaries with Electron-builder is:
See https://github.com/LaserWeb/lw.comm-server/blob/electron_bundler/package.json#L40-L51
The manual instructions are on https://github.com/LaserWeb/lw.comm-server/blob/electron_bundler/README-ELECTRON.md
(Might be worthwhile doing a manual build on your machine to familiarise yourself)
Once the manual run works on a machine, if you have push permissions to the LaserWeb repos (you do now (: ) - then its as simple as running 'npm run nightlylinux' on the linux box, and 'npm run nightlywindows' on a windows box. Note I use git-scm which comes with bash - so it might not work in windows cmd. I use https://git-scm.com/downloads - once installed it adds a Open Git Bash context menu to all folders. I use that as my primary CLI interface for everything on windows lol)
(pull LaserWeb4, run npm run bundle-dev to let Webpack build the /dist/, then copy that /dist/'s content to lw.comms-server(Electron_bundler branch)'s /app
The text was updated successfully, but these errors were encountered: