-
Notifications
You must be signed in to change notification settings - Fork 4
sync: merge upstream v1.0.141 #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
npm dist-tag add command is broken, so publish package multiple times with different tags directly instead
Resolved conflicts: - .github/workflows/publish.yml - removed (keep fork-specific workflows) - .github/workflows/snapshot.yml - kept ours (fork-specific workflow) - packages/desktop/src/context/global-sync.tsx - merged (preserved error handling with upstream color feature) - packages/desktop/src/pages/layout.tsx - merged (added upstream feedback button) - packages/opencode/script/publish.ts - kept ours (fork-specific publishing) - packages/plugin/script/publish.ts - kept ours (skip plugin publish for fork) - packages/script/src/index.ts - kept ours (version logic) - packages/sdk/js/openapi.json - removed (deleted upstream) - packages/sdk/js/script/publish.ts - kept ours (skip SDK publish for fork) - packages/sdk/openapi.json - accepted upstream (openapi schema) - script/publish.ts - kept ours (fork-specific publishing) - bun.lock - regenerated
|
Caution Review failedThe pull request is closed. WalkthroughUpstream sync from v1.0.138 to v1.0.141 introduces architectural event system refactoring (Bus.event → BusEvent.define), workflow reorganization for SDK generation, project management enhancements with color theming and worktree identifiers, desktop UI refinements, and updated API schemas supporting project updates and interleaved reasoning capabilities. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Areas requiring extra attention:
Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (87)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const unsubscribe = Bus.subscribe(FileWatcher.Event.Updated, async (evt) => { | ||
| if (evt.properties.file !== head) return | ||
| if (evt.properties.file.endsWith("HEAD")) return | ||
| const next = await currentBranch() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branch updates skipped on HEAD changes
The VCS watcher now returns immediately when the updated path ends with HEAD, which means branch changes (the only time .git/HEAD changes) no longer trigger a refresh. Previously the handler ran only for HEAD updates; with the inverted condition the branch check and vcs.branch.updated event are skipped unless some unrelated file happens to change afterwards, so the UI can stay on the old branch after a checkout.
Useful? React with 👍 / 👎.
Summary
Resolved Conflicts
.github/workflows/publish.yml.github/workflows/snapshot.ymlpackages/desktop/src/context/global-sync.tsxpackages/desktop/src/pages/layout.tsxpackages/opencode/script/publish.tspackages/plugin/script/publish.tspackages/script/src/index.tspackages/sdk/js/openapi.jsonpackages/sdk/js/script/publish.tspackages/sdk/openapi.jsonscript/publish.tsCloses #102
Summary by CodeRabbit
Release Notes
New Features
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.