Skip to content

Fix cache corruption from partial updates in file refresh #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuv1337 merged 2 commits into from
Nov 14, 2025
Merged

Fix cache corruption from partial updates in file refresh #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
add1bf8
Initial plan
Copilot Nov 14, 2025
416719a
Fix cache corruption bug in refresh function
Copilot Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions packages/opencode/src/file/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,11 @@ export namespace File {
type Entry = { files: string[]; dirs: string[] }
let cache: Entry = { files: [], dirs: [] }
let fetching = false
const fetchEntries = async (result: Entry) => {
const fetchEntries = async () => {
const temp: Entry = { files: [], dirs: [] }
const set = new Set<string>()
for await (const file of Ripgrep.files({ cwd: Instance.directory })) {
result.files.push(file)
temp.files.push(file)
let current = file
while (true) {
const dir = path.dirname(current)
Expand All @@ -135,14 +136,14 @@ export namespace File {
current = dir
if (set.has(dir)) continue
set.add(dir)
result.dirs.push(dir + "/")
temp.dirs.push(dir + "/")
}
}
cache = result
cache = temp
}
const refresh = (result: Entry) => {
const refresh = () => {
fetching = true
fetchEntries(result)
fetchEntries()
.catch((error) => {
if (error instanceof Error && "code" in error && error.code === "ENOENT") return
log.error("failed to refresh files", { error })
Expand All @@ -151,15 +152,12 @@ export namespace File {
fetching = false
})
}
refresh(cache)
refresh()

return {
async files() {
if (!fetching) {
refresh({
files: [],
dirs: [],
})
refresh()
}
return cache
},
Expand Down