Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create reusable FieldSetLegend component #640

Merged
merged 12 commits into from
May 24, 2024
Merged

Create reusable FieldSetLegend component #640

merged 12 commits into from
May 24, 2024

Conversation

jhp0621
Copy link
Contributor

@jhp0621 jhp0621 commented Mar 26, 2024 •
edited
Loading

#631

Release Notes

Author Checklist

  • Add unit test(s)
  • Update version in package.json (see the versioning guidelines)
  • Update documentation (if necessary)
  • Add story to storybook (if necessary)
  • Assign dev reviewer

@jhp0621 jhp0621 marked this pull request as draft March 26, 2024 22:51
@jhp0621 jhp0621 marked this pull request as ready for review March 31, 2024 21:06
@jhp0621 jhp0621 requested review from danparnella and chawes13 April 1, 2024 16:01
chawes13
chawes13 reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@chawes13 chawes13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good! A few documentation nits. Tests passed at 100% coverage 🚀

src/forms/labels/field-set-legend.js Outdated Show resolved Hide resolved
src/forms/labels/field-set-legend.js Outdated Show resolved Hide resolved
src/forms/labels/field-set-legend.js Outdated Show resolved Hide resolved
stories/forms/labels/fieldset-legend.story.js Outdated Show resolved Hide resolved
src/forms/labels/field-set-legend.js Outdated Show resolved Hide resolved
@chawes13
Copy link
Contributor

@jhp0621 where's this one stand?

@jhp0621 jhp0621 requested a review from chawes13 April 29, 2024 14:31
chawes13
chawes13 requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@chawes13 chawes13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but let's switch the file and function name to "fieldset".

package.json Outdated Show resolved Hide resolved
@jhp0621 jhp0621 requested a review from chawes13 May 13, 2024 14:25
@chawes13 chawes13 merged commit 1cfb2c8 into main May 24, 2024
2 checks passed
@chawes13 chawes13 deleted the componentize-fieldset-legend branch May 24, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danparnella danparnella danparnella left review comments

@chawes13 chawes13 chawes13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhp0621 @chawes13 @danparnella