feat(iw4): load leaderboard definitions from raw #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diamante0018
changed the title
diamante0018
force-pushed
the
iw4/load-leaderboarddef
branch
4 times, most recently
from
eb717c5 to
985d5fc
Compare
Laupetin
reviewed
May 25, 2024
src/ObjLoading/Game/IW4/AssetLoaders/AssetLoaderLeaderboard.cpp
Outdated
Show resolved
Hide resolved
src/ObjLoading/Game/IW4/AssetLoaders/AssetLoaderLeaderboard.cpp
Outdated
Show resolved
Hide resolved
src/ObjLoading/Game/IW4/Leaderboard/JsonLeaderboardDefLoader.cpp
Outdated
Show resolved
Hide resolved
src/ObjLoading/Game/IW4/Leaderboard/JsonLeaderboardDefLoader.cpp
Outdated
Show resolved
Hide resolved
src/ObjLoading/Game/IW4/Leaderboard/JsonLeaderboardDefLoader.cpp
Outdated
Show resolved
Hide resolved
diamante0018
force-pushed
the
iw4/load-leaderboarddef
branch
from
985d5fc to
4320e3b
Compare
diamante0018
force-pushed
the
iw4/load-leaderboarddef
branch
from
4320e3b to
2d28f42
Compare
Laupetin
previously approved these changes
Jun 1, 2024
src/ObjLoading/Game/IW4/Leaderboard/JsonLeaderboardDefLoader.cpp
Outdated
Show resolved
Hide resolved
src/ObjLoading/Game/IW4/Leaderboard/JsonLeaderboardDefLoader.cpp
Outdated
Show resolved
Hide resolved
|
I just fixed the two things myself :) But feel free to look at it, might be relevant for the other two games. Thanks for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.