fix: do not normalize asset names when loading assets #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffect is already covered by normalized asset finding from asset pools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asset names were normalized when loading because i assumed all asset names were normalized anyway.
Leaderboards are an obvious counter example to this since their names are all uppercase.
Since the main thing that has be correct is that asset lookup is being done case insensitively, the inteded effect of the original change was to make this happen, but it is now covered already by normalizing asset names for lookup.
So now this reverts back normalizing asset names upon load so you can have leaderboards have uppercase names again for example, as they are in vanilla fastfiles.