-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement mutations with payload, input types and error as data handling #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources
Summary
Introduce mutations with conventions such as payload, input types, and error as handling.
The reasoning for following with those conventions can be found in the resource links above but here's a brief explanation:
Payload types
Schema implementation
Payload types are used with the purpose of being used as the result of a particular mutation.
It enables to evolve the mutation over time without having to directly change a single return type. When scaling an API, mutations often require to return more than just the thing that has been mutated.
Input types
Schema implementation
Having a unique input type per mutation is a convention originally introduced by Relay.
The benefits are the following:
• The input is much more evolvable.
• The mutation can use a single variable on the client-side, which does make it a bit easier to use especially when you start having a lot of arguments.
Errors as data
The approach implemented in this PR uses union
types to represent possible problematic states to the client.
The benefits are the following: