Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all-time stats #108

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Fixed all-time stats #108

merged 3 commits into from
Nov 21, 2024

Conversation

Thiies
Copy link
Collaborator

@Thiies Thiies commented Nov 21, 2024

  • The leaderboard endpoint now sends the player dto instead of the player id
  • Stats are now calculated by profile instead of by player. Calculating by player results in a response containg mutliple player objects of the same profile.
  • For all-time stats the backend sends the player of the active season if any is found. If the player is not in the active season, the latest found player is used

closes #107

Copy link
Collaborator

@LinusBolls LinusBolls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sehr schön, vor allem die comments

@LinusBolls LinusBolls merged commit 5307b9b into main Nov 21, 2024
4 checks passed
@LinusBolls LinusBolls deleted the all-time-stats branch November 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(backend): all-time leaderboard should count players of the same profile together
3 participants