Give nightly release and apk pretty names #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wanted to tidy up the yml and look of the new nightly builds in the release section to match the other release naming.
For example the current nightly release
debug.apkwould instead be uploaded as:Lawnchair.Debug.14-dev.Nightly-7516813-(CI_#729).apkWhich nicely indicates that this is still the app.lawnchair.debug package name, the build branch and Nightly for the version, then the commit hash and CI# of the corresponding tag to easily trace issues reported after it may have been replaced by the next nightly.
The Beta Release APK naming I've attempted to take these cues from, for reference:
Lawnchair.14.0.0.Beta.2.apkThe proper quotes in the commands should resolve the # issue mentioned in the removed comment.
The releases will be titled "Lawnchair Nightly" instead of the simple "nightly" from the tag, which also more matches the release titles of the new betas.
Type of change
✅ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)