Fix floating point arithmetic error #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawnchair/src/app/lawnchair/ui/preferences/components/controls/SliderPreference.kt
Outdated
Show resolved
Hide resolved
|
Done! |
SuperDragonXD
approved these changes
Sep 13, 2024
Goooler
approved these changes
Sep 14, 2024
nulldrf
pushed a commit
to nulldrf/lawnchair
that referenced
this pull request
Sep 19, 2024
* Fix floating point arithmetic error * Change variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes root cause of this crash: #4663 (comment)
Floating point arithmetic rounding causes error in comparison when checking a UI slider's range/steps.
Crash was avoided by changing lower range of slider to 0.3f but using a value of 0.2f causes the app to crash.
Changing a different slider's range value could potentially cause a similar crash in the future so fixing the root cause of the problem is necessary.
Type of change
❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
✅ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)