Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warning regarding string substitution #4802

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

tgex0
Copy link
Contributor

@tgex0 tgex0 commented Sep 11, 2024

Description

Fix compiler warning regarding string substitution in strings.xml.

Type of change

❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
✅ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Goooler
Copy link
Member

Goooler commented Sep 12, 2024

Can you rename all these?

image

@tgex0
Copy link
Contributor Author

tgex0 commented Sep 12, 2024

Sure. I'll do it later today. It's 2am here in the UK just now.

@tgex0
Copy link
Contributor Author

tgex0 commented Sep 12, 2024

I've changed the string substitution tokens in 56 string.xml files.
I could not seem to edit the fa-rIR and iw-rIL files (the token splits).

@Goooler Goooler merged commit 71652d6 into LawnchairLauncher:14-dev Sep 12, 2024
5 checks passed
@tgex0 tgex0 deleted the String_Substitution branch September 12, 2024 13:14
nulldrf pushed a commit to nulldrf/lawnchair that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants