Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Revert "Align widget padding to icons" #4879

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Striffly
Copy link
Contributor

@Striffly Striffly commented Oct 6, 2024

This reverts commit 93cb189.

Description

Following the introduction of this commit, the appearance of the widgets has been modified in terms of width, and they now occupy a much smaller portion of the screen.
As a result, some widgets have significantly lost readability, and there is now too much unused space around them.

Here is an example before the introduction of this commit:
1

And an example after the introduction of this commit:
2

As you can see, the available space for the text inside the widgets is much more limited than before. This is particularly problematic for certain widgets like calendars or task lists.

I suggest reverting to the previous layout or allowing the margin to be configurable.

Type of change

✅ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)

@MrSluffy MrSluffy merged commit 524824e into LawnchairLauncher:14-dev Oct 7, 2024
5 checks passed
@daviessm daviessm mentioned this pull request Oct 7, 2024
@Striffly
Copy link
Contributor Author

Striffly commented Oct 7, 2024

@MrSluffy thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants