Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Evoland & Bing #1077

Closed
wants to merge 0 commits into from
Closed

Conversation

peterge1998
Copy link
Contributor

@peterge1998 peterge1998 commented Feb 28, 2023

Description

Fixes #(issue)

Type of change

❌ Bug fix (non-breaking change which fixes an issue)
✅ : Icon addition (non-breaking change that adds/modifies Lawnicons's icons)
❌ General change (non-breaking change that doesn't fit the above categories like copyediting)

Icons addition information

Icons added

  • Bing
  • Evoland

Copy link
Member

@Chefski Chefski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Could you just sort the links in alphabetical order and do the same in the future?

@Chefski Chefski changed the title add evoland & bing Add Evoland & Bing Feb 28, 2023
@peterge1998
Copy link
Contributor Author

Hey! Could you just sort the links in alphabetical order and do the same in the future?

Why do we not set up a ci job to do this automatically? I hate doing stuff manually that can be done via ci

@peterge1998
Copy link
Contributor Author

peterge1998 commented Mar 1, 2023

Hey! Could you just sort the links in alphabetical order and do the same in the future?

I dont know if I did the sorting correct. Please lets do it automatically

@Chefski
Copy link
Member

Chefski commented Mar 1, 2023

If we can sort the links by name we will setup an Action. In the meantime please try sort manually. I find it annoying too but haven't found anything yet to sort by a specific value.

@peterge1998
Copy link
Contributor Author

If we can sort the links by name we will setup an Action. In the meantime please try sort manually. I find it annoying too but haven't found anything yet to sort by a specific value.

See my comment ;)

@peterge1998
Copy link
Contributor Author

So whats the status of this MR @Chefski ?

@Chefski
Copy link
Member

Chefski commented Mar 4, 2023

It's sorted by component instead of name which isn't what we want necessarily + there's conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants