Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+15 icons, linked 2, modified 2 app names #2084

Merged
merged 31 commits into from
May 12, 2024
Merged

+15 icons, linked 2, modified 2 app names #2084

merged 31 commits into from
May 12, 2024

Conversation

Ahmed-Khalifa
Copy link
Contributor

Description

+15 icons, linked 2, modified 2 app names

Added

Absher (sa.gov.moi/com.elm.android.individual.RoutingActivity)
Crypto Bubbles (net.cryptobubbles/net.cryptobubbles.MainActivity)
Alfagih Hospital (com.dmfh.dmfh/com.dmfh.dmfh.ui.SplashScreen)
ExpertOption (com.expertoption/com.expertoption.MainActivity)
Jarir (com.jarirbookstore.JBMarketingApp/com.yaqut.jarirapp.activities.onboarding.SplashScreen)
M2 (com.m2.exchange/com.m2.exchange.MainActivity)
Mobily (com.mobily.activity/com.mobily.activity.core.navigation.RouteActivity)
NAFATH (sa.gov.nic.myid/sa.gov.nic.myid.MainActivity)
Nahdi (com.nahdi.main/com.nahdi.main.presentation.ui.activity.splash.SplashActivity)
noon (com.noon.buyerapp/com.noon.buyerapp.MainActivity)
Phantom (app.phantom/app.phantom.MainActivity)
RedotPay (com.redotpay/com.redotpay.MainActivity)
Sehhaty (com.lean.sehhaty/com.lean.sehhaty.ui.splash.SplashActivity)
Tawakkalna Emergency (sa.gov.nic.tawakkalna/com.store.android.ui.SplashActivity)
Wafeer (com.app.wafeer/com.app.wafeer.MainActivity)

Linked

ANB Telemoney (telemoneyapp.anb.keystore/telemoneyapp.anb.keystore.launcher_2cfa478945145ffc9dff49d2d860c62dfd80892e28877b2ed1434c45f77637c8 -> anb_telemoney
Tamara (co.tamara.user/co.tamara.user.LaunchActivity -> tamara.svg)

Contributor's checklist

  • I followed the Lawnicons guidelines and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.

Ahmed-Khalifa and others added 24 commits April 29, 2024 15:04
hungerstation (`com.hungerstation.android.web/com.hungerstation.android.web.hungeractivities.MainActivity`)
almanea (`com.almanea.android/com.almanea.android.MainActivity`)
circlys (`com.jmeyte.app/com.example.circlys_v2.MainActivity`)
clicflyer (`main.ClicFlyer/main.ClicFlyer.Login.Splash`)
mada_pay (`com.mada.madapay/com.emcrey.app.activities.SupportActivity`)
* Alkahraba (`sa.com.se.alkahraba/sa.com.se.alkahraba.MainActivity`)
* Alrajhi Bank (`com.alrajhiretailapp/com.alrajhiretailapp.MainActivity`)
* DEXTools (`io.dextools.app/io.dextools.app.ui.splash.SplashActivity`)
* Malaa (`tech.malaa.personal/tech.malaa.personal.MainActivity`)
* SNB Mobile (`com.snb.alahlimobile/com.snb.alahlimobile.MainActivity`)
* Tameeni (`tameeni.com/tameeni.com.MainActivity`)
* Tawakkalna Services (`sa.gov.nic.twkhayat/com.tawakkalna.twkapp.ui.SplashActivity`)
* Alinma App (`com.alinma.retail.mobile.v4/com.alinma.retail.mobile.v4.MainActivity`)
* ANB Telemoney (`telemoneyapp.anb.keystore/telemoneyapp.anb.keystore.MainActivity`)
* BingX (`pro.bingbon.app/pro.bingintl.ui.activity.MainActivity`)
* Bouki (`com.emcrey.riyadbank/com.emcrey.bouki.MainActivity`)
* Panda (`com.todoorstep.store/com.todoorstep.store.ui.activities.splash.SplashActivity`)
* Rabby Wallet (`com.debank.rabbymobile/com.debank.rabbymobile.MainActivity`)
* Tamara (`co.tamara.user/co.tamara.user.MainActivity`)
* Themer (`com.therxmv.telegramthemer/com.therxmv.telegramthemer.ui.MainActivity`)
Modified
alinma_app, alkahraba, alrajhi_bank, anb_telemoney, bouki, rabby_wallet, snb_mobile, tameeni, tawakkalna_services, themer, appfilter.xml
I removed the word app from alinma icon name and in appfilter.xml
reworked the icon
themer.svg brush  stroke to 10px.
Lowered the icon a little bit
@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label May 9, 2024
svgs/crypto_bubbles.svg Show resolved Hide resolved
svgs/dr_alfagih.svg Outdated Show resolved Hide resolved
svgs/m2.svg Show resolved Hide resolved
svgs/nafath.svg Show resolved Hide resolved
svgs/phantom.svg Show resolved Hide resolved
svgs/redotpay.svg Show resolved Hide resolved
svgs/sehhaty.svg Show resolved Hide resolved
svgs/wafeer.svg Show resolved Hide resolved
app/assets/appfilter.xml Show resolved Hide resolved
@x9136 x9136 added the rework The team has requested changes in the issue or PR. label May 10, 2024
@Ahmed-Khalifa Ahmed-Khalifa requested a review from x9136 May 11, 2024 18:10
svgs/crypto_bubbles.svg Show resolved Hide resolved
svgs/m2.svg Show resolved Hide resolved
svgs/nafath.svg Show resolved Hide resolved
svgs/sehhaty.svg Show resolved Hide resolved
@x9136
Copy link
Collaborator

x9136 commented May 11, 2024

I suggest simplifying the process to save your time if you leave comments for me and not for yourself as a mark.

There is no point in telling me what and how you have changed, because I can see it when I do a review. But if, for example, you have a question or a suggestion to do something different from what I suggested, then it makes sense to discuss it.

@Ahmed-Khalifa Ahmed-Khalifa requested a review from x9136 May 12, 2024 10:30
@x9136
Copy link
Collaborator

x9136 commented May 12, 2024

Thanks!

@x9136 x9136 merged commit 2628ec4 into LawnchairLauncher:develop May 12, 2024
4 checks passed
@x9136
Copy link
Collaborator

x9136 commented May 12, 2024

If you would like to get rid of the long commit history, then read how git reset --hard works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants