Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark stable classes and enable Compose Compiler reports #2280

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

@github-actions github-actions bot added the code General code changes label Aug 23, 2024
// Conflicts:
//	app/build.gradle.kts
//	app/src/main/kotlin/app/lawnchair/lawnicons/ui/components/home/IconPreviewGrid.kt
@Goooler Goooler changed the title Enable stability configuration file Mark stable classes and enable Compose Compiler reports Sep 6, 2024
// Conflicts:
//	app/src/main/kotlin/app/lawnchair/lawnicons/ui/destination/Contributors.kt
//	app/src/main/kotlin/app/lawnchair/lawnicons/ui/destination/Home.kt
Copy link
Contributor

@SuperDragonXD SuperDragonXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific advantage/reason to mark these classes as stable instead of using kotlinx.collections.immutable.*?

@Goooler
Copy link
Member Author

Goooler commented Sep 6, 2024

Compose treats immutable collections as stable, now we can mark normal collections stable instead. This will also ensure Compose's smart skipping works efficiently and reduce our package size.

Copy link
Contributor

@SuperDragonXD SuperDragonXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for clarifying.

@Goooler Goooler merged commit a966f85 into develop Sep 6, 2024
4 checks passed
@Goooler Goooler deleted the remove-immutable-collections branch September 6, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code General code changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants