Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+6 icons #2298

Closed
wants to merge 0 commits into from
Closed

Conversation

McIntoshEuan
Copy link
Contributor

@McIntoshEuan McIntoshEuan commented Sep 4, 2024

Description

Added a few icons for common Japanese apps, hope to keep adding more in the future.

Screenshot 2024-09-04 214112

Icons addition information

Added

ICOCA ( jp.co.westjr.android.icocaapp/crc64fa0dbc8111ab4fb7.MainActivity )
JOYFIT ( jp.joyfit.joyfitappandroid/jp.joyfit.joyfitappandroid.MainActivity )
Mynaportal ( jp.go.cas.mpa/jp.go.cas.mpa.presentation.view.eventcontrol.EventControlActivity )
くら寿司 ( jp.co.kura_corpo/jp.co.kura_corpo.SplashActivity_ )
モンベル ( jp.montbell.montbellofficialapp/jp.montbell.montbellofficialapp.SplashActivity )
ヤマレコ ( com.yamareco.memo/com.yamareco.memo.ui )

Contributor's checklist

  • I followed the Lawnicons guidelines and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.+

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Thanks for your contribution!

While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.
  • Approved by the Lawnicons reviewer

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.
  • Approved by the Lawnicons reviewer

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.
  • Approved by the Lawnicons reviewer

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.
  • Approved by the Lawnicons reviewer

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Sep 4, 2024
@McIntoshEuan
Copy link
Contributor Author

McIntoshEuan commented Sep 4, 2024

Build debug APK / check-style (pull_request) wasn't successful. Looking into this.

Edit; Fixed.

Copy link
Collaborator

@x9136 x9136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the canvas size for all icons first.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Sep 5, 2024
@McIntoshEuan McIntoshEuan requested a review from x9136 September 7, 2024 16:00
@McIntoshEuan
Copy link
Contributor Author

Fixed all canvases to 192x192. Also adjusted the naming of some of the apps in the appfilter.xml. (Had the Japanese and English backwards)

app/assets/appfilter.xml Outdated Show resolved Hide resolved
app/assets/appfilter.xml Outdated Show resolved Hide resolved
svgs/icoca.svg Outdated Show resolved Hide resolved
svgs/joyfit.svg Outdated Show resolved Hide resolved
svgs/kurasushi.svg Outdated Show resolved Hide resolved
svgs/mynaportal.svg Outdated Show resolved Hide resolved
svgs/yamareco.svg Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants