Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 9 new icons #2447

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

Asat-103
Copy link

@Asat-103 Asat-103 commented Nov 14, 2024

Description

Added 9 icons under the guidelines. These apps combine to form approximately 45M downloads.

Icons addition information

Added

Digital Rupee by Union Bank of India (org.npci.erupeeUBI)
Internshala (com.internshala.app)
Licious (com.licious
Naplarm (yash.naplarmuno)
NoBroker (com.nobroker.app)
Shell Asia (com.shell.sitibv.shellgoplusindia)
Slam Fitness (com.yoactiv.slamfitness)
TicketNew (ticketnew.android.ui)
Video Converter (com.inverseai.video_converter)

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Nov 14, 2024
Copy link
Contributor

Thanks for your contribution!

We hope that you followed the Lawnicons guidelines and made sure that Lawnicons is built correctly.

While waiting for a brief review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

@x9136
Copy link
Collaborator

x9136 commented Nov 20, 2024

Hey! The icons are so out of line with the Lawnicons guidelines that I got the impression that you ignored the requirements.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Nov 20, 2024
@Asat-103
Copy link
Author

Hey! The icons are so out of line with the Lawnicons guidelines that I got the impression that you ignored the requirements.

Hi! I tried to keep with the guidelines as much as possible to my knowledge, they

  • are within 8-12px in stroke width
  • are within 160px in size
  • have rounded caps
  • 6px corner radius

the mockup I made is not to scale, i just did that to see what it would look like.

If I have made errors could you take the time to mention what specifically I have done wrong, as I was working in Illustrator and somethings might have come out wrong... should I make it in figma or inkscape like the guidelines mentioned?

@x9136
Copy link
Collaborator

x9136 commented Nov 25, 2024

Due to the number of discrepancies, I don't have the opportunity to comment on each icon, but since the bot's message doesn't help:
Screenshot 2024-11-25 at 15 28 38

try

should I make it in figma or inkscape like the guidelines mentioned?

Anywhere, the main thing is to follow the Lawnicons guidelines.

@Asat-103
Copy link
Author

Thank you so much for the quick reply!

I see, there have been some over sights on my end but also some issues with software, I will fix them from scratch and open an other pull request!

Again thank you for the help!

@I21b
Copy link
Contributor

I21b commented Nov 30, 2024

should I make it in figma or inkscape like the guidelines mentioned?

For vector icons making, maybe Figma can do better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants