Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloudmoon #2469

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

freakingdan
Copy link
Contributor

This is my final revision for adding Cloudmoon as list of icons

Cloudmoon (1)

Edited now using Photopea

This is the best that i can do here 😓

Copy link
Contributor

Thanks for your contribution!

We hope that you followed the Lawnicons guidelines and made sure that Lawnicons is built correctly.

Tip

While waiting for a brief and strict review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons. Additionally, you can find and install the debug build of your PR.

Lawnicons guidelines

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Nov 29, 2024
@Johny-adri2
Copy link
Contributor

Johny-adri2 commented Nov 29, 2024

"I prefer my icon unique bruh", but seriously, first of all, why is it a PNG? Secondly, the outline thickness doesn't match with the guidelines. Use a VECTOR GRAPHICS program, something like Adobe Illustrator or Figma, or Inkscape… Heck, use Scratch's BUILT IN vector editor! Here's the corrected for you icon by the way.
https://github.com/user-attachments/assets/f3028825-f053-4098-9079-74d289cd5068
cloudmoon

@x9136
Copy link
Collaborator

x9136 commented Nov 29, 2024

This is the best that i can do here 😓

Even if you add the application activity to the appfilter.xml so that the icon works, it's hard for me to imagine how much the icon will differ from the rest. It strongly doesn't correspond to the Lawnicons guidelines.

Here's the corrected for you icon by the way.

This option doesn't match the Lawnicons guidelines either.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Nov 29, 2024
@freakingdan
Copy link
Contributor Author

Even if you add the application activity to the appfilter.xml so that the icon works, it's hard for me to imagine how much the icon will differ from the rest. It strongly doesn't correspond to the Lawnicons guidelines.

:( i'm maybe not the best but i can see that this icon may not add soon enough
sorry in advance. If someone can correct my mistake here and add another PRs with the real cloudmoon icon, i will be happy ;)

@freakingdan
Copy link
Contributor Author

freakingdan commented Nov 30, 2024

Here's the corrected for you icon by the way.

It doesn't even pass the Lawnicons guidelines though ;(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants