Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor icon improvements #2502

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Minor icon improvements #2502

merged 2 commits into from
Dec 31, 2024

Conversation

x9136
Copy link
Collaborator

@x9136 x9136 commented Dec 31, 2024

Description

I took into account the Lawnicons guidelines.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Dec 31, 2024
Copy link
Contributor

Thanks for your contribution!

We hope that you followed the Lawnicons guidelines and made sure that Lawnicons is built correctly.

Tip

While waiting for a brief and strict review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons. Additionally, you can find and install the debug build of your PR.

Lawnicons guidelines

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

@x9136 x9136 merged commit b20916c into LawnchairLauncher:develop Dec 31, 2024
6 checks passed
RaduBratan added a commit to RaduBratan/Lawnicons that referenced this pull request Jan 1, 2025
commit be70b37
Author: 92 <169070113+I21b@users.noreply.github.com>
Date:   Wed Jan 1 17:43:05 2025 +0900

    +1 icon (LawnchairLauncher#2488)

    * +1 icon

    `5ber.eSIM` `com.ifreegroup.moesim`

    |![old](https://github.com/user-attachments/assets/3d6322a4-b579-4670-89d0-6615b912c3d8)|![new](https://raw.githubusercontent.com/Twive/lawnicons/refs/heads/develop/svgs/_5ber_esim.svg)|
    |---|---|

    * Update _5ber_esim.svg

    * Add files via upload

commit b20916c
Author: Gleb <60105060+x9136@users.noreply.github.com>
Date:   Tue Dec 31 11:08:21 2024 +0300

    Minor icon improvements (LawnchairLauncher#2502)

    * Minor icon improvements

    * Update quizduel.svg

commit 8e6fecc
Author: 92 <169070113+I21b@users.noreply.github.com>
Date:   Tue Dec 31 16:49:47 2024 +0900

    Update README.md (LawnchairLauncher#2487)

commit 3accd38
Author: Gleb <60105060+x9136@users.noreply.github.com>
Date:   Mon Dec 30 14:03:37 2024 +0300

    Minor config.yml fix (LawnchairLauncher#2501)

commit 879bad0
Author: Gleb <60105060+x9136@users.noreply.github.com>
Date:   Mon Dec 30 13:56:53 2024 +0300

    Suspension of icon requests (LawnchairLauncher#2500)

    Added a hint to the issue template.

commit 6289116
Author: SuperDragonXD <70206496+SuperDragonXD@users.noreply.github.com>
Date:   Fri Dec 27 13:35:12 2024 +0800

    Search improvements

    - Improve animations when opening search bar
    - Temporary fix to search bar showing on tall devices; fixes LawnchairLauncher#2495
    - Open first item when pressing search button in IME

commit ddc8641
Author: SuperDragonXD <70206496+SuperDragonXD@users.noreply.github.com>
Date:   Fri Dec 27 11:57:56 2024 +0800

    Cleanup preferences handling

commit 6b371f9
Author: SuperDragonXD <70206496+SuperDragonXD@users.noreply.github.com>
Date:   Wed Dec 25 21:47:58 2024 +0800

    feat: Allow enabling/disabling icon requests

    This can be done via the flag at the website repo, or via the local prefs override at the debug menu.

    TODO: Update link once new form is placed.

commit fcc7be4
Author: Gleb <60105060+x9136@users.noreply.github.com>
Date:   Sat Dec 21 19:35:34 2024 +0300

    Removed the deleted form (LawnchairLauncher#2494)

    * Removed the deleted form

    * Update icon_rebrand.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant