Skip to content

Commit

Permalink
Remove sentry logger debounce
Browse files Browse the repository at this point in the history
This is probably going to result in a high quantity of exceptions, but I
think this is fine. We can add rules as we go to not log certain
exception types.
  • Loading branch information
peppy committed May 10, 2022
1 parent c6112b3 commit 363643a
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions osu.Game/Utils/SentryLogger.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ namespace osu.Game.Utils
/// </summary>
public class SentryLogger : IDisposable
{
private Exception? lastException;

private IBindable<APIUser>? localUser;

private readonly IDisposable? sentrySession;
Expand Down Expand Up @@ -69,11 +67,6 @@ private void processLogEntry(LogEntry entry)
{
if (!shouldSubmitException(exception)) return;

// since we let unhandled exceptions go ignored at times, we want to ensure they don't get submitted on subsequent reports.
if (lastException != null && lastException.Message == exception.Message && exception.StackTrace.StartsWith(lastException.StackTrace, StringComparison.Ordinal)) return;

lastException = exception;

// framework does some weird exception redirection which means sentry does not see unhandled exceptions using its automatic methods.
// but all unhandled exceptions still arrive via this pathway. we just need to mark them as unhandled for tagging purposes.
// easiest solution is to check the message matches what the framework logs this as.
Expand Down

0 comments on commit 363643a

Please sign in to comment.