Merge pull request ppy#18202 from smoogipoo/workaround-freemod-perfor…

…mance Workaround bad performance when selecting all freemods
Lawtrohux · May 10, 2022 · 5af18f9 · 5af18f9
2 parents 886a481 + 8ccf2ee
commit 5af18f9
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/osu.Game/Overlays/Mods/ModSelectScreen.cs b/osu.Game/Overlays/Mods/ModSelectScreen.cs
@@ -192,7 +192,10 @@ protected override void LoadComplete()
 
             State.BindValueChanged(_ => samplePlaybackDisabled.Value = State.Value == Visibility.Hidden, true);
 
-            ((IBindable<IReadOnlyList<Mod>>)modSettingsArea.SelectedMods).BindTo(SelectedMods);
+            // This is an optimisation to prevent refreshing the available settings controls when it can be
+            // reasonably assumed that the settings panel is never to be displayed (e.g. FreeModSelectScreen).
+            if (customisationButton != null)
+                ((IBindable<IReadOnlyList<Mod>>)modSettingsArea.SelectedMods).BindTo(SelectedMods);
 
             SelectedMods.BindValueChanged(val =>
             {