Fix metric middleware panic #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
commented
Sep 19, 2024
| @@ -99,7 +99,7 @@ func NewMetrics(subsystem string) *Metrics { | |||
| Buckets: prometheus.ExponentialBucketsRange(0.05, 1200, 20), | |||
| Help: "Histogram of HTTP server request durations", | |||
| }, []string{ | |||
| "method", "commitment_mode", "DA_cert_version", // no status on histograms because those are very expensive | |||
| "method", // no status on histograms because those are very expensive | |||
There was a problem hiding this comment.
@hopeyen had to remove this because it was causing a revert in the metric middleware, since you weren't passing these labels (because we don't have access to them before the request when this is called):
panic: inconsistent label cardinality: expected 3 label values but got 1 in []string{"GET"}
There might be another way to keep these in, but I suggest merging this first and then figuring out that in your other PR which should also change the behavior of the handlers to use custom errors instead of relying on the values returned along with an err.
samlaf
force-pushed
the
fix-metric-middleware-panic
branch
from
5aaa5c3 to
5e8c5b4
Compare
hopeyen
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent metric changes were causing panics that weren't caught in tests because the tests never use the metrics and logs middlewares. Added testing for those, and fixed the panic.
Fixes Issue
Fixes #
Changes proposed
Screenshots (Optional)
Note to reviewers