Improve local test setup #177
Conversation
samlaf
requested review from
bxue-l2,
teddyknox and
ethenotethan
and removed request for
teddyknox
e2e/setup.go
Outdated
| func init() { | ||
| err := startMinioContainer() | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| err = startRedisContainer() | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| } |
There was a problem hiding this comment.
knit - using an init pattern like this could make our code super hard to import - at least this library
There was a problem hiding this comment.
agree that this sucks... also it could at some point be needed to have new clean instances per test. wanted to talk with you about how to best refactor this.
I didn't see an obvious place where to start these containers. The separation between creating the config (one fct that sets all the config vars) and starting the endpoints makes it hard... because the actual endpoint of the containers are only known after they are started, so we'd need to start them in the "createConfig" function, which feels wrong... perhaps we need yet another function like startDependencyContainers() or something? And we can call it from the test main function?
There was a problem hiding this comment.
On another note though I'm not sure why anyone would want to import this package... do you have anything in mind or just saying in case?
There was a problem hiding this comment.
just saying as an in-case - maybe one day we try importing this into node software directly for cross testing framework integration
There was a problem hiding this comment.
Agree with you, but want to move on to other things for now and worry about this when it actually becomes a problem (perhaps an obvious refactor will also surface once we have an actual need for this). Added a TODO comment: a9ae57b
| minioEndpoint = strings.TrimPrefix(endpoint, "http://") | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
knit - we document the above function but not this one
e2e/setup.go
Outdated
| } | ||
|
|
||
| // startMinioContainer starts a MinIO container and returns the container instance and its endpoint | ||
| func startMinioContainer() error { |
There was a problem hiding this comment.
knit - startMinIOContainer
Fixes Issue
Fixes #175
at least fixes everything with e2e tests. holesky tests are still not runnable locally until we get that private key stored somewhere.
Changes proposed
Screenshots (Optional)
Note to reviewers