Inomurko/iam #70
Merged
Inomurko/iam #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iam and static auth
ethenotethan
approved these changes
Jul 30, 2024
server/config.go
Outdated
Comment on lines
169
to
176
| func toS3CredentialType(s string) store.S3CredentialType { | ||
| if s == string(store.S3CredentialStatic) { | ||
| return store.S3CredentialStatic | ||
| } else if s == string(store.S3CredentialIAM) { | ||
| return store.S3CredentialIAM | ||
| } | ||
| return store.S3CredentialUnknown | ||
| } |
There was a problem hiding this comment.
knit - switch might be more idiomatic
There was a problem hiding this comment.
also it might make more sense for this function to live in store/s3.go
| } | ||
|
|
||
| type S3Store struct { | ||
| cfg S3Config | ||
| client *minio.Client | ||
| stats *Stats | ||
| stats *Stats | ||
| } | ||
|
|
||
| func NewS3(cfg S3Config) (*S3Store, error) { |
There was a problem hiding this comment.
knit - this function could be refactored to support less duplication if we were to add a receiver to S3 config for generating the client credentials func (cfg *Config) Credentials() minio.credentials and only have a single instillation of the client in the s3 constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Fixes Issue
#69
Fixes #
Changes proposed
Screenshots (Optional)
Note to reviewers