Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blob quorum metrics at node #406

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Mar 28, 2024

Why are these changes needed?

Provide visibility to multi quorum blobs at node

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from mooselumph and ian-shim and removed request for mooselumph March 28, 2024 21:35
@@ -31,6 +33,8 @@ type Metrics struct {
AccuBatches *prometheus.CounterVec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to remove AccuBatchesDeprecated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@jianoaix jianoaix merged commit 1cebf06 into Layr-Labs:master Mar 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants