Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grpc size comments #751

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix grpc size comments #751

merged 1 commit into from
Oct 1, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Sep 7, 2024 •
edited
Loading

Why are these changes needed?

proto.Size() returns int, which is 64 bits on 64 bits machine.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from dmanc and bxue-l2 September 7, 2024 00:25
@jianoaix
Copy link
Contributor Author

Ping?

@jianoaix jianoaix merged commit a3eab61 into Layr-Labs:master Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@bxue-l2 bxue-l2 Awaiting requested review from bxue-l2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @dmanc