Instrument the retrieval latency stages #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
approved these changes
Sep 20, 2024
disperser/apiserver/server.go
Outdated
| @@ -702,7 +704,7 @@ func (s *DispersalServer) RetrieveBlob(ctx context.Context, req *pb.RetrieveBlob | |||
| return nil, api.NewResourceExhaustedError(errorString) | |||
| } | |||
| } | |||
|
|
|||
| s.logger.Debug("checked retrieval blob rate limiting", "requesterID", fmt.Sprintf("%s:%s", origin, RetrievalBlobRateType.Plug()), "duration (ms)", time.Since(stageTimer).Milliseconds()) | |||
There was a problem hiding this comment.
nit: could we name labels camelcase? or time.Since(stageTimer).String() should format it in a human readable way then we probably don't need to indicate the unit in the label
There was a problem hiding this comment.
The mixed cap is pretty compatible with golang. Sounds good to let String() to pretty print.
There was a problem hiding this comment.
It's compatible in Golang, but doesn't work nicely when filtering by labels in Loki
There was a problem hiding this comment.
feel free to start a conversation on this topic, and if it's indeed a good idea, make a migration cross the board. It's not that useful to start ad hoc style at random places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We need visibility to understand the retrieval latency, which sometimes goes above 1s (too high).
Checks