Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Disperser and Node service protobuf #784

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Oct 5, 2024

Why are these changes needed?

Adding v2 grpc interfaces for disperser and node

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review October 5, 2024 01:59
@ian-shim ian-shim mentioned this pull request Oct 5, 2024
6 tasks
api/builder/protoc.sh Outdated Show resolved Hide resolved
api/proto/common/common.proto Outdated Show resolved Hide resolved
// Disperser defines the public APIs for dispersing blobs.
service Disperser {
// DisperseBlob accepts blob to disperse from clients.
// This executes the dispersal async, i.e. it returns once the request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
// This executes the dispersal async, i.e. it returns once the request
// This executes the dispersal asynchronously, i.e. it returns once the request

api/proto/disperser/v2/disperser_v2.proto Outdated Show resolved Hide resolved
api/proto/disperser/v2/disperser_v2.proto Show resolved Hide resolved
api/proto/disperser/v2/disperser_v2.proto Show resolved Hide resolved
api/proto/node/v2/node_v2.proto Outdated Show resolved Hide resolved
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@ian-shim ian-shim merged commit 5323e99 into Layr-Labs:master Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants