[payments] numeric incremental updates, query with ordering and lim #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
force-pushed
the
hope/dynamodb-updates
branch
2 times, most recently
from
03900ad to
8cc0e7b
Compare
hopeyen
changed the title
hopeyen
changed the title
hopeyen
force-pushed
the
hope/dynamodb-updates
branch
4 times, most recently
from
131ee44 to
1692ab3
Compare
ian-shim
reviewed
Oct 8, 2024
common/aws/dynamodb/client.go
Outdated
| @@ -156,6 +157,35 @@ func (c *Client) UpdateItem(ctx context.Context, tableName string, key Key, item | |||
| return resp.Attributes, err | |||
| } | |||
|
|
|||
| func (c *Client) IncrementBy(ctx context.Context, tableName string, key Key, itemKey string, itemValue uint64) (Item, error) { | |||
There was a problem hiding this comment.
nit: attr string, value uint64?
(itemValue sounds like it will be assigned this new value)
hopeyen
force-pushed
the
hope/dynamodb-updates
branch
2 times, most recently
from
feb5543 to
a8a6ca9
Compare
ian-shim
approved these changes
Oct 9, 2024
common/aws/dynamodb/client.go
Outdated
| @@ -191,6 +222,23 @@ func (c *Client) QueryIndex(ctx context.Context, tableName string, indexName str | |||
| return response.Items, nil | |||
| } | |||
|
|
|||
| // QueryIndexOrderWithLimit returns all items in the index that match the given key | |||
| func (c *Client) QueryIndexOrderWithLimit(ctx context.Context, tableName string, indexName string, keyCondition string, expAttributeValues ExpresseionValues, forward bool, limit int32) ([]Item, error) { | |||
There was a problem hiding this comment.
test for this method as well?
hopeyen
force-pushed
the
hope/dynamodb-updates
branch
from
1dec83c to
af1d9fe
Compare
hopeyen
force-pushed
the
hope/dynamodb-updates
branch
from
af1d9fe to
a6810c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks