Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate protos workflow #799

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

cody-littley
Copy link
Contributor

@cody-littley cody-littley commented Oct 10, 2024

Why are these changes needed?

Supersedes #787 I still think it's ugly to commit compiled protobuf files, but I can understand the argument that removing them presents short term risks that could be disruptive.

This PR adds a new CI check that will fail if there are .proto changes without the compiled .proto.go files being properly checked in.

I have verified that this check passes when there are no spurious protobuf changes, and fails when I modify a protobuf file without committing the compiled files. This new job runs in parallel with the others and completes in less than a minute, so it shouldn't have any impact on the end-to-end time for checks to pass.

Screenshot 2024-10-10 at 10 12 44 AM

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley cody-littley self-assigned this Oct 10, 2024
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley cody-littley marked this pull request as ready for review October 10, 2024 15:19
@cody-littley cody-littley merged commit 413dde7 into Layr-Labs:master Oct 11, 2024
7 checks passed
@cody-littley cody-littley deleted the validate-protos-workflow branch October 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants