Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Supersedes #787 I still think it's ugly to commit compiled protobuf files, but I can understand the argument that removing them presents short term risks that could be disruptive.
This PR adds a new CI check that will fail if there are
.proto
changes without the compiled.proto.go
files being properly checked in.I have verified that this check passes when there are no spurious protobuf changes, and fails when I modify a protobuf file without committing the compiled files. This new job runs in parallel with the others and completes in less than a minute, so it shouldn't have any impact on the end-to-end time for checks to pass.
Checks